[riot-notifications] [RIOT-OS/RIOT] boards: factorize some nucleo f4/f7/l4 i2c configuration (#9728)

MrKevinWeiss notifications at github.com
Wed Jan 2 12:01:51 CET 2019


MrKevinWeiss commented on this pull request.

So I was able to test on the nucleo-f410rb, f411re and l476rg.  It seems to make sense and looking at the code it appears things are ported correctly.

The one thing (and it may not be for this PR) is the actual clock timings are still different (looking at the scope).  I am not sure if this is due to the overall settings being wrong (in which case the maintenance becomes easier) or if this is a property of the MCUs (in which case combining the clocks may not be the best approach).

I will sift my way through the datasheets to confirm it is the first setting.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/9728#pullrequestreview-188643266
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190102/8ee683ea/attachment.html>


More information about the notifications mailing list