[riot-notifications] [RIOT-OS/RIOT] U8g2: Refactoring and minor fixes (#10693)

Bas Stottelaar notifications at github.com
Thu Jan 3 11:04:21 CET 2019


basilfx commented on this pull request.



> @@ -6,10 +6,10 @@
 The library is originally written for Arduino boards, but it runs just fine on other platforms, as long as the right drivers are available.
 
 ## Usage
-Just put `USEPKG += u8g2` in your Makefile and `#include "u8g2.h"` to your code. Refer to the [U8g2 wiki](https://github.com/olikraus/u8g2/wiki) for more information on the API.
+Just put `USEPKG += u8g2` in your Makefile and `#include "u8g2.h"` into your code. In case you intend to use SPI/I2C, you should put `#include "u8x8_riot.h"` in your code as well, and use the methods efined there. Refer to the [U8g2 wiki](https://github.com/olikraus/u8g2/wiki) for more information on the API.

>From a compatibility point of view I don't really like this. I prefer to only include `u8g2.h` and have the package sort it all out.

I know this requires patching, but it's a trade-off.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10693#pullrequestreview-188951405
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190103/586e6789/attachment-0001.html>


More information about the notifications mailing list