[riot-notifications] [RIOT-OS/RIOT] stm32_common/i2c: fix wrong speed parameters for stm32l4 and stm32f7 (#9804)

Alexandre Abadie notifications at github.com
Thu Jan 3 13:51:21 CET 2019


aabadie requested changes on this pull request.

Please rebase. Otherwise, it's ok for the driver changes and default use of HSI.
Once done, I'll re-test on different boards.

> @@ -203,6 +203,7 @@ static const i2c_conf_t i2c_config[] = {
         .sda_af         = GPIO_AF4,
         .bus            = APB1,
         .rcc_mask       = RCC_APB1ENR1_I2C1EN,
+        .rcc_sw_mask    = RCC_CCIPR_I2C1SEL_1, /* HSI (16 MHz) */

With #9728 being merged, this change also needs to be applied to `boards/common/stm32/cfg_i2c1_pb8_pb9.h`

> @@ -150,6 +150,7 @@ static const i2c_conf_t i2c_config[] = {
         .sda_af         = GPIO_AF4,
         .bus            = APB1,
         .rcc_mask       = RCC_APB1ENR_I2C1EN,
+        .rcc_sw_mask    = RCC_DCKCFGR2_I2C1SEL_1, /* HSI (16 MHz) */

This conflicts now that #9728 is merged, but this change can also just be applied to boards/common/stm32/cfg_i2c1_pb8_pb9.h.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/9804#pullrequestreview-188997577
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190103/687d29d5/attachment.html>


More information about the notifications mailing list