[riot-notifications] [RIOT-OS/RIOT] net/hdlc: initial hdlc layer (#9200)

Martine Lenders notifications at github.com
Thu Jan 3 14:35:00 CET 2019


miri64 requested changes on this pull request.



> +/**
+ * @brief HDLC Frame types
+ */
+typedef enum {
+    HDLC_FRAME_TYPE_INFORMATION = 0, /**< represents i(nformation) frame */
+    HDLC_FRAME_TYPE_SUPERVISORY = 1, /**< represents s(upervisory) frame*/
+    HDLC_FRAME_TYPE_UNNUMBERED  = 3, /**< represents u(numbered) frame */
+} hdlc_frame_type_t;
+
+/**
+ * @brief Data type to represent an HDLC header.
+ *
+ *  +----------+----------+----------+
+ *  |   Flag   | Address  | Control  |
+ *  | 01111110 | 11111111 | 00000011 |
+ *  +----------+----------+----------+

I'm unsure how this translates to the header defined below.

> +/**
+ * @brief HDLC Frame types
+ */
+typedef enum {
+    HDLC_FRAME_TYPE_INFORMATION = 0, /**< represents i(nformation) frame */
+    HDLC_FRAME_TYPE_SUPERVISORY = 1, /**< represents s(upervisory) frame*/
+    HDLC_FRAME_TYPE_UNNUMBERED  = 3, /**< represents u(numbered) frame */
+} hdlc_frame_type_t;
+
+/**
+ * @brief Data type to represent an HDLC header.
+ *
+ *  +----------+----------+----------+
+ *  |   Flag   | Address  | Control  |
+ *  | 01111110 | 11111111 | 00000011 |
+ *  +----------+----------+----------+

For it to be rendered correctly as pixelart in the rendered doc, this needs to be indented some spaces (not sure how many, please check yourself with `make doc`)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/9200#pullrequestreview-189011499
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190103/82adf11a/attachment-0001.html>


More information about the notifications mailing list