[riot-notifications] [RIOT-OS/RIOT] U8g2: Refactoring and minor fixes (#10693)

Petr notifications at github.com
Thu Jan 3 18:09:33 CET 2019


pvyleta commented on this pull request.



>  
-    i2c_t dev = (i2c_t) u8g2->dev;
+    i2c_t dev = I2C_DEV(u8x8_riot_ptr->device_index);

I did not like the fact, that I would store a value of type i2c_t or spi_t in int, therefore I assumed this to be more clear solution, however, if you feel this is not suitable, I can change it - what type to use then? plain int?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10693#discussion_r245068440
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190103/d60de1cd/attachment.html>


More information about the notifications mailing list