[riot-notifications] [RIOT-OS/RIOT] U8g2: Refactoring and minor fixes (#10693)

Petr notifications at github.com
Thu Jan 3 18:29:07 CET 2019


> Thanks for improving this driver. However, I do have my doubts, which I first need to check by testing this.
> 
> It was [by design](https://github.com/RIOT-OS/RIOT/blob/master/tests/pkg_u8g2/main.c#L105-L109) to use the memory-hungry method to specify pins. U8g2 offers interface libraries, which [depend](https://github.com/olikraus/u8g2/blob/d5776edced36b7eb7a935721bf7e87d8a7c587dc/cppsrc/U8x8lib.h#L182) on the pins, unfortunately. I definately think this is a valuable addition, that could co-exist (end user can then make trade-off to either use a less-compatbible but memory-efficient implementation).

I have to disagree - on the contrary my implementation is compatible with the code you are referring, as the original code is defining 'pins' as a [member of u8x8_struct](https://github.com/olikraus/u8g2/blob/d5776edced36b7eb7a935721bf7e87d8a7c587dc/csrc/u8x8.h#L353), however, there is already member 'pins' hidden behind the macro U8X8_USE_PINS, so when that macro is defined, the original code fails to compile. Furthermore, this macro should not be ever needed for RIOT, because as far as I understand it, it is basically hidin all Arduino-related functionality and should never be needed in RIOT


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10693#issuecomment-451216437
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190103/8bf34d5a/attachment.html>


More information about the notifications mailing list