[riot-notifications] [RIOT-OS/RIOT] cpu/atmega_common/uart: Fix uart baud calculation (#10699)

ZetaR60 notifications at github.com
Sun Jan 6 20:32:59 CET 2019


ZetaR60 requested changes on this pull request.

NACK, until we understand what the exact difference is. The current calculation is the same as what is in `util/setbaud.h` in avr-libc, and I assume the authors know the ATmega well. I am not sure why it is different, and a brief search around the web does not reveal why they chose this method. If you mathematically factor the equation, it comes to `clock/(16*baud) - 0.5` rather than `clock/(16*baud) - 1`. The code was added in #5617, which claims it is more accurate, but did not give a justification.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10699#pullrequestreview-189641327
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190106/5aedfee3/attachment.html>


More information about the notifications mailing list