[riot-notifications] [RIOT-OS/RIOT] cpu/atmega_common/uart: Fix uart baud calculation (#10699)

ZetaR60 notifications at github.com
Sun Jan 6 20:47:33 CET 2019


ZetaR60 commented on this pull request.



> @@ -98,10 +98,10 @@ static void _set_brr(uart_t uart, uint32_t baudrate)
     }
 #endif
 #if defined(UART_DOUBLE_SPEED)

We should have a comment here, explaining:
1. This has the effect of rounding the result to the nearest number.
2. It is the same as `util/setbaud.h`
3. and don't change it to what the datasheet says.

Otherwise this will happen again, since at first glance it is not clear at all what this equation does!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10699#pullrequestreview-189641739
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190106/d72c7a4f/attachment-0001.html>


More information about the notifications mailing list