[riot-notifications] [RIOT-OS/RIOT] ifconfig: Add manual CCA operation (#10649)

Cenk Gündoğan notifications at github.com
Mon Jan 7 11:57:17 CET 2019

cgundogan requested changes on this pull request.

Tested on native (not supported message) and on an iotlab-m3 node. Works great. ACK in general. My comment regarding the trailing line feed is just a matter of taste. In case you disagree, please dismiss my change request.

> @@ -980,13 +980,20 @@ static void _l2filter_usage(const char *cmd)
+static void _cca_usage(const char *cmd)
+    printf("usage: %s <if_id> cca\n", cmd);
+    puts("       perform a clear channel assessment and print the result\n");

The line feed at the end is IMO unnecessary. When calling `ifconfig help` it produces an empty line between the `cca` and `stat reset` usages. I have no strong opinion about this, but for my taste I would prefer no line feed at all, since the usage text is already indented.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190107/3e3e605d/attachment.html>

More information about the notifications mailing list