[riot-notifications] [RIOT-OS/RIOT] gnrc_netif: introduce distinction if an interface supports 6Lo or if it performs ND according to RFC 6775 (#10499)

Martine Lenders notifications at github.com
Mon Jan 7 17:06:08 CET 2019


miri64 commented on this pull request.



> -        netif->ops->set(netif, &opt);
+    switch (netif->device_type) {
+        case NETDEV_TYPE_IEEE802154: {
+            /* see https://tools.ietf.org/html/rfc6775#section-5.2 */
+            uint16_t src_len = IEEE802154_LONG_ADDRESS_LEN;
+            gnrc_netapi_opt_t opt = { .opt = NETOPT_SRC_LEN,
+                                      .data = &src_len,
+                                      .data_len = sizeof(src_len) };
+
+            /* XXX we are supposed to be in interface context here, so use driver
+             * directly everything else would deadlock anyway */
+            netif->ops->set(netif, &opt);
+            /* intentionally falls through */
+        }
+        case NETDEV_TYPE_BLE:
+        case NETDEV_TYPE_NRFMIN:

> I'm still rolling through the changes and discussions. I'm a bit slower than you

In some cases this could be better (see all my "oops"s and "argh"s ;-D)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10499#discussion_r245705936
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190107/2e18ccec/attachment-0001.html>


More information about the notifications mailing list