[riot-notifications] [RIOT-OS/RIOT] drivers/pulse_counter: refactor the prototypes of read funcs (#10716)

Ga√ętan Harter notifications at github.com
Mon Jan 7 17:49:30 CET 2019


Note for this module, during the introduction I pushed to not discard the const qualifier and use an indirection for the modified part but there were arguments that lying API were not a problem and better done this way so I gave up.
https://github.com/RIOT-OS/RIOT/pull/10716

I however, at that time did not thought that it was just a `saul` issue and not the driver itself so good to fix the driver to not use const and not force an indirection there.

Instead of needing to discard the const qualifier in the function, I thought about casting the getter and setter functions when setting the `saul_driver_t` instead, would that be better ? https://github.com/RIOT-OS/RIOT/pull/7883#discussion_r152270624


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10716#issuecomment-452000475
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190107/0f7e38b5/attachment-0001.html>


More information about the notifications mailing list