[riot-notifications] [RIOT-OS/RIOT] gnrc_sixlowpan_frag: unroll recursion (#10681)

Martine Lenders notifications at github.com
Mon Jan 7 20:39:33 CET 2019

miri64 commented on this pull request.

 void rbuf_add(gnrc_netif_hdr_t *netif_hdr, gnrc_pktsnip_t *pkt,
               size_t offset, unsigned page)
+    if (_rbuf_add(netif_hdr, pkt, offset, page) == RBUF_ADD_REPEAT) {

Mh... Aren't you just biased by seeing the previous version? A newcomer to this will see "ah the function is called twice at most". No explanation needed. A while loop would have required more explaining how it wouldn't result in an endless loop ;) 

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190107/67c5338f/attachment.html>

More information about the notifications mailing list