[riot-notifications] [RIOT-OS/RIOT] drivers: Add driver for the LTC4150 coulomb counter (#9653)

Sebastian Meiling notifications at github.com
Tue Jan 8 11:22:34 CET 2019


smlng commented on this pull request.



> +
+/**
+ * @name    Set default configuration parameters for the LTC4150
+ * @{
+ */
+#ifndef LTC4150_PARAM_INT
+#define LTC4150_PARAM_INT             (GPIO_PIN(0, 4))
+#endif
+#ifndef LTC4150_PARAM_POL
+#define LTC4150_PARAM_POL             (GPIO_UNDEF)
+#endif
+#ifndef LTC4150_PARAM_SHUTDOWN
+#define LTC4150_PARAM_SHUTDOWN        (GPIO_PIN(0, 5))
+#endif
+#ifndef LTC4150_PARAM_PULSES
+#define LTC4150_PARAM_PULSES          (45700)

to clarify (from my side) on the suggested `UL` suffix: 

1. we had lots of issue with signed/unsigned comparison errors/warnings, hence the `U`
2. RIOT also supports 8bit platforms such as the atmega arduinos and (IIRC) it was mostly required to explicitly state `UL`, bc w/o any suffix or just `U` `45700 ` will not fit into a 16bit int.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/9653#discussion_r245943559
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190108/b6f771eb/attachment.html>


More information about the notifications mailing list