[riot-notifications] [RIOT-OS/RIOT] cpu/esp32: GPIO macro cleanup in periph_cpu.h (#10662)

Alexandre Abadie notifications at github.com
Wed Jan 9 14:32:58 CET 2019


aabadie commented on this pull request.



>  static void _esp_eth_phy_power_enable_gpio(bool enable)
 {
     assert(EMAC_ETHERNET_PHY_CONFIG.phy_power_enable);
 
+    if (EMAC_PHY_POWER_PIN == GPIO_UNDEF) {

This seems unrelated to this PR, or maybe I'm missing something ?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10662#pullrequestreview-190726391
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190109/68fd9eb9/attachment-0001.html>


More information about the notifications mailing list