[riot-notifications] [RIOT-OS/RIOT] pkg/wakaama: bump version (#10738)

José Alamos notifications at github.com
Wed Jan 9 15:12:27 CET 2019


jia200x commented on this pull request.



> +Date: Wed, 16 May 2018 11:30:02 +0200
+Subject: [PATCH] fixed alignment problem in lwm2m_data_t
+
+---
+ core/liblwm2m.h | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/core/liblwm2m.h b/core/liblwm2m.h
+index 3f16a6d..53616bf 100644
+--- a/core/liblwm2m.h
++++ b/core/liblwm2m.h
+@@ -299,7 +299,6 @@ typedef struct _lwm2m_data_t lwm2m_data_t;
+ 
+ struct _lwm2m_data_t
+ {
+-    lwm2m_data_type_t type;

@moenoel is this safe? E.g wakaama code could eventually cast `_lwm2m_data_t` to `lwm2m_data_type_t` because address_of(_lwm2m_data_t) == addess_of(_lwm2m_data_t->type). With this change, address_of(_lwm2m_data_t) == address_of(_lwm2m_data_t->id).

Do you remember the reason behind this?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10738#pullrequestreview-190743248
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190109/c9e0ffee/attachment.html>


More information about the notifications mailing list