[riot-notifications] [RIOT-OS/RIOT] cortexm.inc.mk: detect 'arm-none-eabi-gcc' from ubuntu bionic (#10404)

Martine Lenders notifications at github.com
Wed Jan 9 17:13:46 CET 2019


miri64 requested changes on this pull request.

I set-up a VM using https://app.vagrantup.com/ubuntu/boxes/bionic64 and installed the toolchain via `apt-get`:

```sh
sudo apt-get update
sudo apt-get install gcc-arm-none-eabi unzip build-essential
arm-none-eabi-gcc --version
```

```
arm-none-eabi-gcc (15:6.3.1+svn253039-1build1) 6.3.1 20170620
Copyright (C) 2016 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
```

However, when following the testing procedures I don't get the expected result:

```sh
RIOT_CI_BUILD=1 BOARD=samr21-xpro make --no-print-directory -C examples/default/ 
```
```
Building application "default" for "samr21-xpro" with MCU "samd21".
make[1]: Warning: File '/home/vagrant/RIOT/examples/default/bin/samr21-xpro/riotbuild/riotbuild.h' has modification time 1 s in the future
make[2]: Warning: File '/home/vagrant/RIOT/examples/default/bin/samr21-xpro/riotbuild/riotbuild.h' has modification time 0.56 s in the future
make[2]: warning:  Clock skew detected.  Your build may be incomplete.
make[2]: Warning: File '/home/vagrant/RIOT/examples/default/bin/samr21-xpro/riotbuild/riotbuild.h' has modification time 0.16 s in the future
make[2]: warning:  Clock skew detected.  Your build may be incomplete.
make[1]: warning:  Clock skew detected.  Your build may be incomplete.
make: Warning: File '/home/vagrant/RIOT/examples/default/bin/samr21-xpro/stdio_uart.a' has modification time 0.027 s in the future
   text	   data	    bss	    dec	    hex	filename
  47436	    148	   6044	  53628	   d17c	/home/vagrant/RIOT/examples/default/bin/samr21-xpro/default.elf
make: warning:  Clock skew detected.  Your build may be incomplete.
```

> +# Ubuntu bionic gcc-arm-none-eabi compiler is not supported
+# Both when using gnu and llvm toolchains
+#
+#     /usr/bin/arm-none-eabi-gcc --version | head -n 1
+#     arm-none-eabi-gcc (15:6.3.1+svn253039-1build1) 6.3.1 20170620
+#
+ARM_GCC_UNSUPPORTED += 15:6.3.1%  # ubuntu bionic, ignore 'svn' build part
+
+# Should not raise an error on the host system version when building in docker
+ifneq (1,$(BUILD_IN_DOCKER))
+  ifneq (,$(filter $(ARM_GCC_UNSUPPORTED),$(ARM_GCC_VERSION)))
+    $(warning $(TARGET_ARCH)-gcc version not supported)
+    $(warning $(shell $(TARGET_ARCH)-gcc --version | head -n 1))
+    $(warning The currently recommanded version is the one installed in the riotdocker image)
+    $(warning https://github.com/RIOT-OS/riotdocker/blob/master/Dockerfile)
+    ifeq (1,$(WERROR))

>From the error message below I would expect it to be checked with `ifneq (0,$(WERROR))`

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10404#pullrequestreview-190801448
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190109/7e610c3c/attachment-0001.html>


More information about the notifications mailing list