[riot-notifications] [RIOT-OS/RIOT] drivers/w5100: Fixed netdev_driver_t::recv() API (#10412)

Marian Buschsieweke notifications at github.com
Wed Jan 9 18:44:17 CET 2019


maribu commented on this pull request.



>  
         /* read the actual data into the given buffer if wanted */
         if (in_buf != NULL) {
+            /* Is provided buffer big enough? */
+            if (len > max_len) {
+                spi_release(dev->p.spi);
+                return -ENOBUFS;

Yes, sorry. I created this PR when the exact semantics of that case where still in discussion and I forgot to update this PR to the final decision. (I will check tomorrow the other related PRs as well, as they might have similar issues.)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10412#discussion_r246475700
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190109/05081be1/attachment-0001.html>


More information about the notifications mailing list