[riot-notifications] [RIOT-OS/RIOT] make: handle disabled default modules before dependencies (#10744)

Kaspar Schleiser notifications at github.com
Thu Jan 10 12:03:54 CET 2019


### Contribution description

Currently, default modules can be disabled by adding the name to ```DISABLE_MODULE```.
Unfortunately, this gets parsed *after* resolving the dependencies.

This makes it impossible to disable e.g., stdio_uart and implicitly periph/uart. The dependency parsing would select periph/uart (as it is dependend on stdio_uart), but later stdio_uart would be dropped, leaking the dependency.

This PR moves ```DISABLE_MODULE``` before dependency resolution.

### Testing procedure

Correct compilation of all applications should suffice.

### Issues/PRs references

#10741
You can view, comment on, or merge this pull request online at:

  https://github.com/RIOT-OS/RIOT/pull/10744

-- Commit Summary --

  * make: handle disabled default modules before dependencies

-- File Changes --

    M Makefile.include (5)

-- Patch Links --

https://github.com/RIOT-OS/RIOT/pull/10744.patch
https://github.com/RIOT-OS/RIOT/pull/10744.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10744
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190110/6e484892/attachment.html>


More information about the notifications mailing list