[riot-notifications] [RIOT-OS/RIOT] sock_dns: fix out-of-bound errors (#10740)

Marian Buschsieweke notifications at github.com
Thu Jan 10 12:35:58 CET 2019


maribu commented on this pull request.



>      }
 
     for (unsigned n = 0; n < ntohs(hdr->ancount); n++) {
-        bufpos += _skip_hostname(bufpos);
+        int tmp = _skip_hostname(buf, len, bufpos);

But I would not block this PR on cosmetic stuff (`ssize_t` will likely be internally the same as `int` anyway), as this can be fixed later and the out-of-bound errors are more urgent.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10740#discussion_r246726603
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190110/712869f0/attachment.html>


More information about the notifications mailing list