[riot-notifications] [RIOT-OS/RIOT] make: handle disabled default modules before dependencies (#10744)

Gaƫtan Harter notifications at github.com
Mon Jan 14 15:56:44 CET 2019


The only definitions of `DEFAULT_MODULE` were in `makefiles/defaultmodules.inc.mk` and one in `cpu/msp430_common/Makefile.include` for some reason, so has no bad impact now when looking at which modules are inside.

However, I do not really understood the issue that it will solve. The values in `DEFAULT_MODULE` are rather generic mechanisms that are included in a normal firmware, and modules you are supposed to find there. 

I also mix a bit the order with depends on is dependent on so cannot really see the goal right now.

If A depends on B, you disable B, but still request A. I would maybe expect it to fail, not silently add B because it is a dependency. I do not think that you should able to say add and remove something at the same time.
Even more right now when it is for generic things like there is in the `DEFAULT_MODULE` list.

But we may indeed be missing a mechanism for your need.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10744#issuecomment-454032765
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190114/557a8985/attachment.html>


More information about the notifications mailing list