[riot-notifications] [RIOT-OS/RIOT] cpu/saml1x: add support for SAML10 and SAML11 MCUs (Cortex-M23) (#10653)
notifications at github.com
Tue Jan 15 13:57:09 CET 2019
> the gpio driver is broken with interrupts
On which board ? L10 or L11 ?
> I found the saml21 and saml1x peripheral implementations very close. I won't ask you to factorize in this PR though, but I see room for improvement here.
Yes, this should be factorize (later). I had not idea how to reuse SAML21 drivers without adding another dependency. IMHO, the best way to do is merge timer, rtc and rtt driver to sam0_common. I'll work on this later I swear.
> tests/periph_rtc and tests/periph_rtt doesn't work:
> tests/periph_flashpage doesn't build, it needs to be adapted.
I probably miss this driver.
> gpio_params.h is missing but saul_gpio is included with the saul_default module
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications