[riot-notifications] [RIOT-OS/RIOT] tools/print_toolchain_versions.sh: use lsb_release. (#10770)

Sebastian Meiling notifications at github.com
Tue Jan 15 16:16:33 CET 2019


smlng requested changes on this pull request.



>  get_os_info() {
     local os="$(uname -s)"
     local osname="unknown"
     local osvers="unknown"
     if [ "$os" = "Linux" ]; then
-        osname="$(cat /etc/os-release | grep ^NAME= | awk -F'=' '{print $2}')"

why not have `if [ -f /etc/os-release ]; then` before that and use `lsb_release` otherwise, and if that's not there either then its `Unknown OS` (or so).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10770#pullrequestreview-192697141
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190115/88e7fcf3/attachment.html>


More information about the notifications mailing list