[riot-notifications] [RIOT-OS/RIOT] cpu/esp32: GPIO macro cleanup in periph_cpu.h (#10662)

Sebastian Meiling notifications at github.com
Wed Jan 16 11:23:07 CET 2019


> All of them generate some kind of an ordinal which doesn't correspond to the pin at the chip. Rather, this ordinal is used in gpio_* function to map it on the right pin of the chip. From my point of view, GPIO_PIN(x,y) does not mean the pin of the chip but the y-th pin at x-th port.

that's only partly right, I think - because for most other CPUs there is at least some relation chip and order of the GPIO PIN number and the corresponding pin on the CPU, i.e. GPIO0 < GPIO1 < GPIO2 ... 

But for the ESPs it seems to be all over the place 😄 Anyway, my initial fear was that the `GPIO_PIN` macro might not work here as expected, but I now see there are further macros and code that do the correct mapping.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10662#issuecomment-454727896
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190116/b67c0d7b/attachment.html>


More information about the notifications mailing list