[riot-notifications] [RIOT-OS/RIOT] sys/crypto/aes: avoid UB by explicit unsigned integer promotion (#10785)

Kaspar Schleiser notifications at github.com
Wed Jan 16 15:33:44 CET 2019


### Contribution description

Fixing undefined behavior through implicit integer promotion of uint8_t to int.

### Testing procedure

Binary result should be identical.

To see the error messages:

- merge #10782 
- compile unittests with "UBSAN_ENABLE=1 UBSAN_MODE=msg_recover make"
- run unittests, see aes errors

### Issues/PRs references

Found using #10782.
You can view, comment on, or merge this pull request online at:

  https://github.com/RIOT-OS/RIOT/pull/10785

-- Commit Summary --

  * sys/crypto/aes: avoid UB by explicit unsigned integer promotion

-- File Changes --

    M sys/crypto/aes.c (7)

-- Patch Links --

https://github.com/RIOT-OS/RIOT/pull/10785.patch
https://github.com/RIOT-OS/RIOT/pull/10785.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10785
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190116/8a646726/attachment.html>


More information about the notifications mailing list