[riot-notifications] [RIOT-OS/RIOT] cpu/saml1x: add support for SAML10 and SAML11 MCUs (Cortex-M23) (#10653)

Alexandre Abadie notifications at github.com
Wed Jan 16 16:07:23 CET 2019


aabadie requested changes on this pull request.

I retested with saml11-xpro and still found small things with the saul gpio, see below.

Also the `tests/buttons` doesn't work. Maybe the exti array needs an update (haven't checked the datasheet). Or there is something else with the peripheral driver ?

I'm running some tests on samr30-xpro (saml21 based) to check everything is ok.

> +#include "board.h"
+#include "saul/periph.h"
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+/**
+ * @brief    GPIO pin configuration
+ */
+static const  saul_gpio_params_t saul_gpio_params[] =
+{
+    {
+        .name = "LED(orange)",
+        .pin = LED0_PIN,
+        .mode = GPIO_OUT

For me saml11-xpro, the LED and buttons are inverted.
```suggestion
        .mode = GPIO_OUT,
        .flags = (SAUL_GPIO_INVERTED | SAUL_GPIO_INIT_CLEAR)
```

> +#endif
+
+/**
+ * @brief    GPIO pin configuration
+ */
+static const  saul_gpio_params_t saul_gpio_params[] =
+{
+    {
+        .name = "LED(orange)",
+        .pin = LED0_PIN,
+        .mode = GPIO_OUT
+    },
+    {
+        .name = "Button(SW0)",
+        .pin  = BTN0_PIN,
+        .mode = BTN0_MODE

```suggestion
        .mode = BTN0_MODE,
        .flags = SAUL_GPIO_INVERTED
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10653#pullrequestreview-193142149
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190116/17a8a607/attachment.html>


More information about the notifications mailing list