[riot-notifications] [RIOT-OS/RIOT] pkg/jerryscript: namespace BUILD_DIR variable (#10789)
notifications at github.com
Wed Jan 16 17:57:27 CET 2019
### Contribution description
I forgot to git grep when merging `BUILD_DIR` and I found issues about it.
BUILD_DIR was introduced but the variable was already used by
`pkg/jerryscript` so there is a name collision.
Namespace it to prevent issues.
### Testing procedure
When building in docker, `build` will be created but empty.
There is no more other usages now in the repository:
git grep '(BUILD_DIR)'
Makefile.include:override BUILD_DIR := $(abspath $(BUILD_DIR))
makefiles/docker.inc.mk: $(Q)mkdir -p $(BUILD_DIR)
makefiles/docker.inc.mk: -v '$(BUILD_DIR):$(DOCKER_BUILD_ROOT)/build' \
### Issues/PRs references
Original PR https://github.com/RIOT-OS/RIOT/pull/10038
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
* pkg/jerryscript: namespace BUILD_DIR variable
-- File Changes --
M pkg/jerryscript/Makefile.jerryscript (12)
-- Patch Links --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications