[riot-notifications] [RIOT-OS/RIOT] periph/spi: extend available clock speeds (#8324)

MrKevinWeiss notifications at github.com
Wed Jan 16 18:22:37 CET 2019


Hmmm I wonder if this would make #9804 harder to fix...

> Some drivers re-implement this enum in their periph_cpu, so I guess these would be broken only when someone would try with a 'new' speed.
Some other, like stm32 use this enum directly and in the case of stm32, there is const static array for prescaler values, which would lead to out of bounds access if one try a new value.

Seems like it is still unaddressed.  Just from looking it may cause some unpleasant bugs.  Maybe along with this some protections/checks/error codes should be added so that if something is unimplemented it doesn't cause problems.

I probably won't block but I think some groundwork needs to either be done before or with this PR.  Nice to have though!

If nobody uses it I expect everything works but if they try it will break some things...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/8324#issuecomment-454864798
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190116/2f2683a0/attachment.html>


More information about the notifications mailing list