[riot-notifications] [RIOT-OS/RIOT] fmt: fix fmt_s32_dec() and fmt_s64_dec() sign bit handling (#10784)

Kaspar Schleiser notifications at github.com
Thu Jan 17 11:11:03 CET 2019


> `unsigned negative = (val < 0);` and then using `negative` in an addition comes close to black voodoo for me.

Anyhow,  that is not relevant for this PR, right? The code was like that before.

How do you think about using the extra variable vs. using the ternary operator in the final function call?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10784#issuecomment-455116374
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190117/804b77a0/attachment-0001.html>


More information about the notifications mailing list