[riot-notifications] [RIOT-OS/RIOT] fmt: fix fmt_s32_dec() and fmt_s64_dec() sign bit handling (#10784)
notifications at github.com
Thu Jan 17 11:27:50 CET 2019
miri64 approved this pull request.
ACK. Code looks fine to me and the unittests still run. The edge-cases are tested somewhat hidden here https://github.com/RIOT-OS/RIOT/blob/d34bf526c125e835146fc609944b0c187d40f864/tests/unittests/tests-fmt/tests-fmt.c#L285-L297 and here https://github.com/RIOT-OS/RIOT/blob/d34bf526c125e835146fc609944b0c187d40f864/tests/unittests/tests-fmt/tests-fmt.c#L348-L365 so it is assured the change doesn't break them.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications