[riot-notifications] [RIOT-OS/RIOT] gnrc_netif: check all required options on initialization (#10532)

Marian Buschsieweke notifications at github.com
Thu Jan 17 13:55:20 CET 2019


maribu requested changes on this pull request.

Looks code-wise good. I think some code was incorrectly merged, so comment above.

> @@ -287,6 +287,11 @@ int gnrc_netif_ndp_addr_len_from_l2ao(gnrc_netif_t *netif,
                     return -EINVAL;
             }
 #endif  /* defined(MODULE_NETDEV_IEEE802154) || defined(MODULE_XBEE) */
+#if defined(MODULE_CC110X)
+        case NETDEV_TYPE_CC110X:
+            (void)opt;
+            return sizeof(uint8_t);
+#endif  /* defined(MODULE_CC110X) */

Above added code seems to be added by accident, e.g. error during a merge. (See lines 257-261 above, the contain the same code. This should not compile with `cc110x` because of the duplicated case.)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10532#pullrequestreview-193608400
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190117/d80e6a82/attachment.html>


More information about the notifications mailing list