[riot-notifications] [RIOT-OS/RIOT] gnrc_netif: check all required options on initialization (#10532)

Martine Lenders notifications at github.com
Thu Jan 17 14:37:46 CET 2019


miri64 commented on this pull request.



> @@ -1156,6 +1156,99 @@ static void _configure_netdev(netdev_t *dev)
 #endif
 }
 
+#ifdef DEVELHELP
+/* checks if a device supports all required options and functions */
+static void _test_options(gnrc_netif_t *netif)
+{
+#if (GNRC_NETIF_L2ADDR_MAXLEN > 0) || GNRC_IPV6_NIB_CONF_6LN

The ifdef is wrong... It should be

```suggestion
#if ((GNRC_NETIF_L2ADDR_MAXLEN > 0) && GNRC_IPV6_NIB_CONF_6LN) || \
    MODULE_GNRC_SIXLOWPAN_ND
```

But since the `(void)dummy_addr` doesn't seem to have any implications code-sizewise, I go for that.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10532#discussion_r248672366
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190117/3a142e8f/attachment.html>


More information about the notifications mailing list