[riot-notifications] [RIOT-OS/RIOT] cpu/saml1x: add support for SAML10 and SAML11 MCUs (Cortex-M23) (#10653)

Dylan Laduranty notifications at github.com
Fri Jan 18 09:17:59 CET 2019


I think I have found the issue for the periph_flashpage : 
the erase command is broken for SAM0.
Procedure to test
use test_last to write the page, read to check if it's ok, now use erase (lastpage-2), re-read the page
Page is not blank at the end but still fill with test_last data.
I was able to reproduce this on SAML11 AND SAML21.
This seems to cause us pain for SAML10/SAML11 but SAML21 just doesn't care.
@fedepell Sorry to bother you but could you confirm it on your side that the erase command doesn't work as expected on your SAML21 ?

If @fedepell confirms it is a bug, I think we should open another PR to fix it.

Of course I have a patch for this :)
`NVMCTRL->ADDR.reg = (((uint32_t)page_addr) >> 1);`
must become
`NVMCTRL->ADDR.reg = (((uint32_t)page_addr) >> 1) << 1;`


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10653#issuecomment-455462960
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190118/1e7d9d34/attachment-0001.html>


More information about the notifications mailing list