[riot-notifications] [RIOT-OS/RIOT] boot: Moved stdio_init() into periph_init() (#10806)

Marian Buschsieweke notifications at github.com
Sat Jan 19 07:00:06 CET 2019


Oh, you noticed that ugly hack in the MSB-A2. If I remember correctly, `periph_init()` is to be called by `cpu_init()`. The lack of `cpu_init()` for MSB-A2 lead to the quick and dirty fix for the MSB-A2 which hopefully gets replaced be a proper fix...

Maybe we can try a proper fix for the HiFive1 from the beginning, as it is not a legacy board.

Am 18. Januar 2019 23:01:34 MEZ schrieb kenrabold <notifications at github.com>:
>The PR as is breaks the HiFive1 board. The code for the board was never
>setup to call periph_init(), so the modifications stop all stdio
>output. Easy fix however. Similar to the msba2 mods, you can add the
>periph_init() call in board.c for HiFive1:
> 
>```
>    /* Initialize newlib-nano library stubs */
>    nanostubs_init();
>
>    /* Initialize peripherals */
>    periph_init();
>}
>
>```
>(and the #include "periph/init.h" )
>
>You will also need to update the Makefile.include in boards\hifive1 to
>include the periph modules:
>
>
>```
># Export the peripheral drivers to be linked into the final binary:
>export USEMODULE += periph
>
># include common periph code
>export USEMODULE += periph_common
>
>```
>
>
>
>
>-- 
>You are receiving this because you were mentioned.
>Reply to this email directly or view it on GitHub:
>https://github.com/RIOT-OS/RIOT/pull/10806#issuecomment-455702016

-- 
Via mobile phone

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10806#issuecomment-455752774
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190118/5b661d64/attachment.html>


More information about the notifications mailing list