[riot-notifications] [RIOT-OS/RIOT] gnrc_mac: add timeout module. (#5949)

Martine Lenders notifications at github.com
Sat Jan 19 11:37:38 CET 2019


miri64 requested changes on this pull request.



> +
+/* Return index >= 0 if found timeout, -ENONENT if not found */
+static int _gnrc_mac_find_timeout(gnrc_mac_timeout_t *mac_timeout, gnrc_mac_timeout_type_t type)
+{
+    assert(mac_timeout);
+    assert(mac_timeout->timeout_num);
+
+    for (unsigned i = 0; i < mac_timeout->timeout_num; i++) {
+        if (mac_timeout->timeouts[i].type == type) {
+            return i;
+        }
+    }
+    return -ENOENT;
+}
+
+inline bool gnrc_mac_timeout_is_running(gnrc_mac_timeout_t *mac_timeout,

This needs to be `static inline`.

```suggestion
static inline bool gnrc_mac_timeout_is_running(gnrc_mac_timeout_t *mac_timeout,
```

This is what LLVM is complaining about.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/5949#pullrequestreview-194352564
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190119/335efcdd/attachment-0001.html>


More information about the notifications mailing list