[riot-notifications] [RIOT-OS/RIOT] atmega: refactor cpu/board code and build/flash variables (#9130)

Francisco Acosta notifications at github.com
Mon Jan 21 15:38:15 CET 2019


kYc0o commented on this pull request.



> +# export the peripheral drivers to be linked into the final binary
+USEMODULE += atmega_common_periph
+USEMODULE += periph_common
+
+# Export the peripheral drivers to be linked into the final binary, for now
+# only atmega126rfr2 has periph drivers
+ifeq ($(CPU), atmega256rfr2)
+  USEMODULE += periph
+endif
+
+# the atmel port uses uart_stdio
+USEMODULE += uart_stdio
+
+# explicitly tell the linker to link the syscalls and startup code.
+# without this the interrupt vectors will not be linked correctly!
+UNDEF += $(BINDIR)/atmega_common/startup.o

I'll make a quick test to see if it's harmful. So far it seems an old compile/linking issue, which for now it doesn't make any trouble but maybe also not any sense.

Another thing is that now we're not using the "automatic" provided ld files anymore, since #9781, so the line is very likely obsolete.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/9130#discussion_r249473510
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190121/4103e7dc/attachment.html>


More information about the notifications mailing list