[riot-notifications] [RIOT-OS/RIOT] cpu/esp32: fix of buffer sizes and length checking in esp_eth and esp_wifi (#10834)

Gunar Schorcht notifications at github.com
Mon Jan 21 15:42:29 CET 2019


### Contribution description

This PR provides a fix of buffer sizes and length checks in `esp_wifi` and `esp_eth` netdev drivers. Since complete MAC frames are handled by these netdev drivers, `ETHERNET_MAX_LEN` has to be used instead of ETHERNET_DATA_LEN for buffer sizes and length checks.

### Testing procedure

Compile and flash `examples/gnrc_networking` for `esp_wifi`
```
CFLAGS='-DESP_WIFI_SSID=\"<your SSID>\" -DESP_WIFI_PASS=\"your passphrase\"' \
USEMODULE="esp_wifi" make BOARD=esp32-wroom-32 -C examples/gnrc_networking flash
```
or `esp_eth`
```
USEMODULE="esp_wifi" make BOARD=esp32-olimex-evb -C examples/gnrc_networking flash
```
and ping a machine in your LAN from the ESP32 node, e.g.,
```
ping6 fe80::5ecf:7fff:fe80:3f08 1392
```
It should at least work with a ICMPv6 data size of 1392 bytes.

### Issues/PRs references

See also discussion in PR #10792 


You can view, comment on, or merge this pull request online at:

  https://github.com/RIOT-OS/RIOT/pull/10834

-- Commit Summary --

  * cpu/esp32: fix of maximum frame length in esp_eth
  * cpu/esp32: fix of maximum frame length in esp_wifi

-- File Changes --

    M cpu/esp32/esp-eth/esp_eth_netdev.c (4)
    M cpu/esp32/esp-eth/esp_eth_netdev.h (4)
    M cpu/esp32/esp-wifi/esp_wifi_netdev.c (4)
    M cpu/esp32/esp-wifi/esp_wifi_netdev.h (4)

-- Patch Links --

https://github.com/RIOT-OS/RIOT/pull/10834.patch
https://github.com/RIOT-OS/RIOT/pull/10834.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10834
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190121/cff7a033/attachment-0001.html>


More information about the notifications mailing list