[riot-notifications] [RIOT-OS/RIOT] dist/pythonlibs: provide unittest TestCase wrapper for testrunner (#10431)

Gaƫtan Harter notifications at github.com
Mon Jan 21 17:43:12 CET 2019


I would split in two commits, the first one where `setup_child` and `teardown_child` are declared as non private functions, which could be re-used somewhere else.
And the second one introducing the `unittest.TestCase`.

And as `testrunner` was changed to a package, `PexpectTestCase` could be put in its own module `testrunner/unittest.py`.

> e.g. this whole section in #10392 could be methods of a PexpectTestCase class that also contains all the interaction stuff (like pktbuf_empty(), add_neighbor(), del_neighbor(), etc.) with the node as methods:

In the long term, I am in favor or providing these methods in a non test class, so in your case would result in a testcase method `self.spawn.add_neighbor(neigh)` or `self.node.add_neighbor` it not called `spawn` but starting to go in this direction in parallel is still a good thing in my opinion.

Providing a base class for this is in my goals during this release.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10431#issuecomment-456135420
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190121/ad1e7fee/attachment.html>


More information about the notifications mailing list