[riot-notifications] [RIOT-OS/RIOT] RFC: UART enhanced settings (#10743)

Mohamed notifications at github.com
Tue Jan 22 07:54:01 CET 2019


bluephoton commented on this pull request.



> +#if defined(USART_CR1_M1)
+static inline void uart_stop(uart_t uart)
+{
+    uint32_t cr1;
+
+    cr1 = dev(uart)->CR1;
+
+    /* disbale transmit */
+    cr1 &= USART_CR1_TE;
+    dev(uart)->CR1 = cr1;
+
+    /* wait for transmission completion */
+    while (!(dev(uart)->ISR & USART_ISR_TC)) {}
+
+    /* disable UART */
+    cr1 &= USART_CR1_UE;

```suggestion
    cr1 &= ~USART_CR1_UE;
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10743#pullrequestreview-194856435
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190121/b617763d/attachment-0001.html>


More information about the notifications mailing list