[riot-notifications] [RIOT-OS/RIOT] cpu/sam0_common: remove unneeded GCLK_SLOW setup in i2c driver (#10839)

Dylan Laduranty notifications at github.com
Tue Jan 22 09:42:48 CET 2019

The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.

### Contribution description
This PR removes the SERCOMx_GLCK_SLOW clock setup from the I2C driver.
According to [SAML21](http://ww1.microchip.com/downloads/en/DeviceDoc/60001477A.pdf), [SAMD21](http://ww1.microchip.com/downloads/en/DeviceDoc/SAMD21-Family-DataSheet-DS40001882D.pdf) and [SAML10](http://ww1.microchip.com/downloads/en/DeviceDoc/SAM-L10L11%20Family-DataSheet%20-%20DS60001513B.pdf) datasheets, this clock is used for SMBus timeouts features but RIOT doesn't use them at all. 
Look for `GCLK_SERCOM_SLOW` within the datasheet for more information.
In addition, this clock should be feed with 32kHz clock source not xx MHz (which is the case now)
Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes

### Testing procedure
Pick the SAM0 board you want, play with any I2C sensors.
Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output

### Issues/PRs references
Found this while adding I2C support for SAML10/SAML11 in #10653 

Examples: Fixes #1234. See also #5678. Depends on PR #9876.

Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.

You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * cpu/sam0_common: remove unneeded GCLK_SLOW setup in i2c driver

-- File Changes --

    M cpu/sam0_common/periph/i2c.c (17)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190122/f3246f2f/attachment.html>

More information about the notifications mailing list