[riot-notifications] [RIOT-OS/RIOT] RFC: UART enhanced settings (#10743)

MrKevinWeiss notifications at github.com
Tue Jan 22 14:09:14 CET 2019


MrKevinWeiss requested changes on this pull request.

Tested on nucleo-f401re, 115200, test message: "123\n"
Tested against scope decode
Tested modes passed 7e2, 7e1, 7o1, 7o2, 8n1, 8n2, 8o2, 8o1, 8e1, 8e2
Test modes failed with message: 7n2, 7n1
Test modes failed without message: 9xx

Seems to be in decent shape, maybe fix the silent error?

> +
+/**
+ * @brief   Override databits length values
+ * @{
+ */
+#define HAVE_UART_DATABITS_T
+typedef enum {
+    UART_DATABITS_8 = 0,        /**< 8 databits */
+    UART_DATABITS_5 = 0x02,     /**< not supported */
+#if defined(USART_CR1_M1)
+    UART_DATABITS_6 = 3,        /**< 6 databits */
+#else
+    UART_DATABITS_6 = 0x02,     /**< not supported */
+#endif
+    UART_DATABITS_7 = 1,        /**< 7 databits */
+    UART_DATABITS_9 = 0x02      /**< not supported */

I can't see any failure of 9 bits are set, if it not supported maybe it should be removed or at least give an indication.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10743#pullrequestreview-194988820
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190122/f07b0a42/attachment-0001.html>


More information about the notifications mailing list