[riot-notifications] [RIOT-OS/RIOT] boards/hifive1: fix CLOCK_CORECLOCK (#10805)

kenrabold notifications at github.com
Tue Jan 22 22:45:51 CET 2019


Yes, it is fine. That #define is not used anywhere except in the new PR to support SPI. I don't have anything to test that the SPI code works, but the change above is OK. The board.c for the HiFive1 inits the main clock  in board_init_clock() and it uses a different #define for the desired clock rate. The UART driver then checks what the board freq is dynamically to compute the clock divider for the selected baud rate. That way the UART doesn't have to rely on getting the clock rate based on a set #define. Perhaps the SPI code can do something similar.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10805#issuecomment-456575598
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190122/f2de6261/attachment.html>


More information about the notifications mailing list