[riot-notifications] [RIOT-OS/RIOT] net/nanocoap: validate option length (#10823)

Sebastian Meiling notifications at github.com
Wed Jan 23 08:50:29 CET 2019


smlng commented on this pull request.



> @@ -499,7 +499,35 @@ static size_t _encode_uint(uint32_t *val)
     return size;
 }
 
-static unsigned _put_delta_optlen(uint8_t *buf, unsigned offset, unsigned shift, unsigned val)
+/*
+ * Writes CoAP Option header. Expected to be called twice to write an option:

nice documentation, 

I would suggest (even though .c files are not included with Doxygen) you might want to use proper tags here, i.e.,

- `@brief` at the beginning 
- `@param` and
- `@return`

for the latter two you missed to use the `@`, the advantage is that someone could still run doxygen including .c files to generate a nice docu.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10823#pullrequestreview-195381296
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190122/4d34daa6/attachment.html>


More information about the notifications mailing list