[riot-notifications] [RIOT-OS/RIOT] boards: add support for kw41z-mini (#10846)
notifications at github.com
Wed Jan 23 09:10:43 CET 2019
The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.
### Contribution description
This adds support for [kw41z-mini](https://openlabs.co/OSHW/kw41z-mini). It's much the same as frdm-kw41z except it has half the memory and no dcdc. Also no load caps on the crystals. I plan to be making them regularly unless the stm32wb ends up being a much better chip.
Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes
### Testing procedure
Radio support needs #7107
Everything I've tested seems to be working. I haven't taken a close look at low power modes yet (with #7897) aside from getting down to about 5uA and being unable to wake afterwards. I didn't pursue it further but I plan to soonish.
I just realized I've never tested I2C and I don't have anything handy to test with, but if it works on frdm-kw41z then it must work on kw41z-mini because they use the same I2C pins and I copied and pasted the I2C configuration.
- [x] ADC
- [x] DAC
- [x] GPIO
- [x] SPI
- [ ] I2C
- [x] RTC
- [x] networking (with #7107)
Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output
### Issues/PRs references
Continuing the discussion from #9934, I don't see much room for combining common kw41z files. The only things I see that could be picked out are timer and xtimer configurations and `spi_clk_config`, but I don't know that it's worth it for that and there can be valid reasons for a board to change the timer.
Examples: Fixes #1234. See also #5678. Depends on PR #9876.
Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
* boards: add support for kw41z-mini
-- File Changes --
A boards/kw41z-mini/Makefile (3)
A boards/kw41z-mini/Makefile.dep (10)
A boards/kw41z-mini/Makefile.features (13)
A boards/kw41z-mini/Makefile.include (6)
A boards/kw41z-mini/board.c (33)
A boards/kw41z-mini/doc.txt (5)
A boards/kw41z-mini/include/adc_params.h (77)
A boards/kw41z-mini/include/board.h (116)
A boards/kw41z-mini/include/gpio_params.h (127)
A boards/kw41z-mini/include/periph_conf.h (270)
M tests/unittests/Makefile (1)
-- Patch Links --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications