[riot-notifications] [RIOT-OS/RIOT] pkg/openwsn: re-integrate the network stack as a package (#8570)

Martine Lenders notifications at github.com
Wed Jan 23 14:56:59 CET 2019


miri64 commented on this pull request.

Oops I had these review comments never commited and they seem to be in here for a while now ...

> +    rtt_init();
+}
+
+void sctimer_set_callback(sctimer_cbt cb)
+{
+    DEBUG("sctimer_set_callback\n");
+    sctimer_vars.sctimer_cb = cb;
+}
+
+/**
+   \brief set compare interrupt
+ */
+void sctimer_setCompare(uint32_t val)
+{
+    DEBUG("sctimer_setCompare\n");
+    // enable the compare interrupt

Comment style

> +
+void sctimer_set_callback(sctimer_cbt cb)
+{
+    DEBUG("sctimer_set_callback\n");
+    sctimer_vars.sctimer_cb = cb;
+}
+
+/**
+   \brief set compare interrupt
+ */
+void sctimer_setCompare(uint32_t val)
+{
+    DEBUG("sctimer_setCompare\n");
+    // enable the compare interrupt
+    /*
+       if (current Timer counter - val < TIMERLOOP_THRESHOLD){

Can be removed, I guess

> + */
+void sctimer_init(void)
+{
+    DEBUG("sctimer_init\n");
+    memset(&sctimer_vars, 0, sizeof(sctimer_vars_t));
+    rtt_init();
+}
+
+void sctimer_set_callback(sctimer_cbt cb)
+{
+    DEBUG("sctimer_set_callback\n");
+    sctimer_vars.sctimer_cb = cb;
+}
+
+/**
+   \brief set compare interrupt

Doxygen style

> @@ -0,0 +1,132 @@
+From 0c967954f444044cbc5c51d25230a5ca6cfa1383 Mon Sep 17 00:00:00 2001
+From: PeterKietzmann <peter.kietzmann at haw-hamburg.de>
+Date: Thu, 8 Feb 2018 10:19:38 +0100
+Subject: [PATCH 1/6] Add Makefiles

Have a look at the current lwIP package. Adding makefiles is now possible without a patch ;-).

> @@ -0,0 +1,72 @@
+From 587609720250906a6ae5b6d5bd5c1daca2dd3349 Mon Sep 17 00:00:00 2001
+From: PeterKietzmann <peter.kietzmann at haw-hamburg.de>
+Date: Thu, 8 Feb 2018 11:25:18 +0100
+Subject: [PATCH 3/6] Comment out problematic includes

Why are they problematic? A short reasoning in the description might be beneficial

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/8570#pullrequestreview-185385480
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190123/4847ce95/attachment.html>


More information about the notifications mailing list