[riot-notifications] [RIOT-OS/RIOT] cpu/atmega_common: do not export LINKFLAGS (#10854)

Gaëtan Harter notifications at github.com
Wed Jan 23 18:42:07 CET 2019


### Contribution description

cpu/atmega_common: do not export LINKFLAGS

This prevent evaluating `LINKFLAGS` when not needed and when building
in docker so does not produce errors if `avr-ld` is not installed.

```
BUILD_IN_DOCKER=1 BOARD=arduino-mega2560  make --no-print-directory -C examples/hello-world/ clean
/srv/ilab-builds/workspace/git/riot_master/makefiles/toolchain/gnu.inc.mk:18: objcopy not found. Hex file will not be created.
/bin/sh: 1: avr-ld: not found
```

It removes the `/bin/sh: 1: avr-ld: not found`

### Testing procedure

On a machine without `avr` installed, try compiling in docker for any board using `atmega_common/Makefile.include` and notice the `/bin/sh: 1: avr-ld: not found` errors.

A shorter output is simply calling `clean` as described in the commit message.
With this PR the `avr-ld: not found` should not be printed anymore.


### Issues/PRs references

Found while testing `arduino-mega2560` on a machine without `avr`.
Depends on https://github.com/RIOT-OS/RIOT/pull/10853
Tracking issue on removing exports and immediate evaluations https://github.com/RIOT-OS/RIOT/issues/10850

You can view, comment on, or merge this pull request online at:

  https://github.com/RIOT-OS/RIOT/pull/10854

-- Commit Summary --

  * makefiles/vars.inc.mk: do not export LINKFLAGS
  * cpu/atmega_common: do not export LINKFLAGS

-- File Changes --

    M cpu/atmega_common/Makefile.include (4)
    M makefiles/vars.inc.mk (2)

-- Patch Links --

https://github.com/RIOT-OS/RIOT/pull/10854.patch
https://github.com/RIOT-OS/RIOT/pull/10854.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10854
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190123/18ec7b29/attachment.html>


More information about the notifications mailing list