[riot-notifications] [RIOT-OS/RIOT] sys/shell: Exit the shell on ctrl-D or ctrl-C. (#10788)

Thomas Stilwell notifications at github.com
Wed Jan 23 19:23:26 CET 2019


benemorius commented on this pull request.



> @@ -227,7 +227,7 @@ static int readline(char *buf, size_t size)
         }
 
         int c = getchar();
-        if (c < 0) {
+        if (c < 0 || c == '\x03' || c == '\x04') {

I don't think it's right to exit on ^C. We should cancel the current line and print a new prompt. This is consistent with how bash and friends behave. Like this: benemorius at a946c44c7650d2ed3fea55d429485d7f8bdc30bf

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10788#pullrequestreview-195672641
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190123/0e28d1a1/attachment-0001.html>


More information about the notifications mailing list