[riot-notifications] [RIOT-OS/RIOT] gnrc_ipv6_nib: release when not queuable on AR (#10860)
notifications at github.com
Fri Jan 25 00:10:11 CET 2019
The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.
### Contribution description
As mentioned in https://github.com/RIOT-OS/RIOT/pull/10859#issuecomment-457228518 I was still able to cause leaks in the packet buffer. This was because when a new queue entry is tried to be allocated for a neighbor who's address is currently tried to be resolved there was no error case before. The packet that was tried to be put in the queue was thus not released and stayed in the packet buffer for ever.
Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes
### Testing procedure
I started a native instance with `gnrc_pktbuf_cmd` compiled in. I then used `scapy` to spam the node with ICMPv6 echo requests with non-existent source addresses:
sendp(Ether(dst="<native l2addr>") / IPv6(src="fe80::1", dst="<native lladdr>") / ICMPv6EchoRequest(), iface="tapbr0", count=100)
Without this PR the *replies* stick in the packet buffer. With it the packet buffer stays empty.
Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output
### Issues/PRs references
Examples: Fixes #1234. See also #5678. Depends on PR #9876.
Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
* gnrc_ipv6_nib: release when not queuable on AR
-- File Changes --
M sys/net/gnrc/network_layer/ipv6/nib/nib.c (5)
-- Patch Links --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications