[riot-notifications] [RIOT-OS/RIOT] pkg/semtech-loramac: add timer calibration (#10868)

José Alamos notifications at github.com
Fri Jan 25 14:30:58 CET 2019

The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.

### Contribution description
This PR adds 2 macros for calibrating LoRaMAC reception windows timers, as described in [RX Window Calibration](https://stackforce.github.io/LoRaMac-doc/_p_o_r_t_i_n_g__g_u_i_d_e.html) in the original Semtech documentation.

Macros are added to the `@config` group so can be found in Doxygen.
- `#define LORAMAC_DEFAULT_MIN_RX_SYMBOLS                  (12)`
Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes

### Testing procedure
- Try to perform OTA and send confirmed messages in LoRaMAC
- Check if the macros appear in Doxygen.

Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output

### Issues/PRs references

Examples: Fixes #1234. See also #5678. Depends on PR #9876.

Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.

You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * pkg/semtech-loramac: remove timer tweaks from contrib
  * pkg/semtech-loramac: add timer calibration functions
  * loramac: add macros for default timer calibration values
  * pkg/semtech-loramac: set default timer calibration values

-- File Changes --

    M pkg/semtech-loramac/contrib/semtech_loramac.c (4)
    M pkg/semtech-loramac/contrib/semtech_loramac_getset.c (20)
    M pkg/semtech-loramac/contrib/semtech_loramac_radio.c (2)
    M pkg/semtech-loramac/contrib/semtech_loramac_timer.c (7)
    M pkg/semtech-loramac/include/semtech_loramac.h (16)
    M sys/include/net/loramac.h (60)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190125/b08dc1d9/attachment-0001.html>

More information about the notifications mailing list