[riot-notifications] [RIOT-OS/RIOT] tests: provide unittests for gnrc_sixlowpan_frag/rbuf (#10851)

Martine Lenders notifications at github.com
Fri Jan 25 16:25:48 CET 2019


> Just one thing: when I remove the changes in the `sys/net/gnrc/network_layer/sixlowpan/frag/rbuf.h/c`, except the one related to TEST_SUITES, the unittests are still passing. So are these changes really required ?

There are three changes you might be talking about so I split my argument up into 3 bullet points

1. The addition of 
   https://github.com/RIOT-OS/RIOT/blob/d31fc84e43d0bb7d78305e2bcb0cb5b371e77988/sys/net/gnrc/network_layer/sixlowpan/frag/rbuf.h#L95-L97
   If I remove that I get a compile error for the test
   ```
   /home/mlenders/Repositories/RIOT-OS/RIOT/tests/gnrc_sixlowpan_frag/main.c: In function ‘_first_non_empty_rbuf’:
   /home/mlenders/Repositories/RIOT-OS/RIOT/tests/gnrc_sixlowpan_frag/main.c:212:14: error: implicit declaration of function ‘rbuf_entry_empty’ [-Werror=implicit-function-declaration]
         if (!rbuf_entry_empty(&rbuf[i])) {
              ^
   cc1: all warnings being treated as errors
   ```
   so I guess you did not remove that.
2. The assert in
   https://github.com/RIOT-OS/RIOT/blob/d31fc84e43d0bb7d78305e2bcb0cb5b371e77988/sys/net/gnrc/network_layer/sixlowpan/frag/rbuf.c#L96-L99
   and the type change required for that (otherwise, `frag->offset` is not exposed) in
   https://github.com/RIOT-OS/RIOT/blob/d31fc84e43d0bb7d78305e2bcb0cb5b371e77988/sys/net/gnrc/network_layer/sixlowpan/frag/rbuf.c#L90
   I reasoned with in https://github.com/RIOT-OS/RIOT/pull/10851#discussion_r250289990
3. Various replacements of `(rbuf[i].super.pkt == NULL)` with `rbuf_entry_empty(&rbuf[i])`. These I did to keep the code consistent but yes, are functionally the same. I can remove them, but I'd prefer not to, since I want to keep the consistency (especially with regards to the tests).



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10851#issuecomment-457608813
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190125/24f93d84/attachment-0001.html>


More information about the notifications mailing list