[riot-notifications] [RIOT-OS/RIOT] uncrustify: add auto uncrustify with blacklist (#8519)

Kaspar Schleiser notifications at github.com
Fri Jan 25 17:36:33 CET 2019


> Not really. In fact, rules are quite clear. E.g
> 
> ```
> L001 No trailing whitespace
> L002 Don't use tab characters
> L003 No leading and no trailing empty lines
> L004 Line cannot be too long
> L005 There should not be too many consecutive empty lines
> L006 Source file should not be too long
> ```
> 
> This rules are not ambiguous at all. They don't produce false positives.

Ok, now I see. Vera++ only checks for compliance to those rules. Most code complies to that already, so arming it now would be painless. More rules can be added later.

Obviously Vera++ and uncrustify would need to agree on their style descisions. Otherwise users might run uncrustify over code that Vera++ likes, just to have Vera++ complain afterwards, or the other way around.

Looking at the rules, there are already some that uncrustify doesn't care about (many consecutive empty lines, source file too long), but which make sense for the CI.

It would make total sense to use Vera++ for the checks uncrustify cannot do. Still I believe that having the (much simpler) uncrustify as authoritative baseline formatting would make devs and reviewers life a little easier.
As long as the tools check different (or guaranteed to be the same) stuff, I'm happy to use both.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/8519#issuecomment-457633344
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190125/b68eb0e2/attachment.html>


More information about the notifications mailing list